feat: add operation for cycling crosswalk tags#1160
Conversation
Bonkles
left a comment
There was a problem hiding this comment.
Left a couple of comments about strings and the regex used to determine the feature's appropriateness.
Bonkles
left a comment
There was a problem hiding this comment.
HI @RitaDee - instead of creating an entirely new operation, let's instead augment the existing cycle highway tags operation to do both things. I apologize for not making this requirement clearer in my original issue writeup.
We'll need you to take the following actions:
- Move the existing cycle crosswalk tag functionality into the main
cycle_highway_tag.jsfile. - Ensure that it works in both cases: highways get their tags cycled correctly, AND crosswalks get their tags cycled correctly.
- Remove the new
cycle_crosswalk_tag:core.yaml entry and subentries for title, key, description, but keep the new annotation and put it under the cycle_highway_tag entry.
I hope that makes sense!
|
@Bonkles, it does make sense. |
Bonkles
left a comment
There was a problem hiding this comment.
Needs refactoring! The highway logic and crossing logic should be kept separate, depending on what the user has selected, we should conditionally do one thing (cycle a crossing's tags) or the other (cycle a highway's tags).
Bonkles
left a comment
There was a problem hiding this comment.
Left a couple comments directly on the cycle_highway_tags source!
|
This looks pretty good to me and the tests are passing, so I'm going to squash-merge it back to |
Description
This PR introduces a new feature (an operation function) that enables users to easily cycle through crosswalk tags within the OSM editing context. The operation supports keyboard shortcuts, provides a tooltip with descriptive information, and includes annotation.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes: #1154
Mobile & Desktop Screenshots/Recordings
Before:
Screen.Recording.2023-11-01.at.09.26.14.mov
After:
Screen.Recording.2023-11-01.at.09.29.54.mov
Added tests?
Added to documentation?